Merge pull request #204 from dillontkh/Fix-LongNameQRCodeGeneration

Fix generation of QR codes for long names

docs/DeveloperGuide.md

@@ -229,11 +229,11 @@ Thus, we chose to only generate QR codes when the person is successfully added t
 
 This approach was also taken for the editing/deleting of QR codes.
 
-#### QR Code Image Naming
+#### QR Code Image File Naming
 
-QR codes associated with a client are named according to the format: [FULL NAME]_[PHONE_NUMBER].png
+QR codes associated with a client are saved in the `data/qrcodes` folder as `.png` files, and named according to the following format: 
 
-This format was chosen as clients with the same name and phone number are not allowed in FitBook, so these two fields are enough to uniquely identify every client.
+* [HASHCODE].png, where [HASHCODE] is the result of the `hashCode()` function of a `Person`.
 
 ### Deleting a client from FitBook
 

src/main/java/seedu/address/logic/QrCodeGenerator.java

@@ -84,7 +84,6 @@ private static String createVCardString(Person person) {
      * @return the file path for the QR code
      */
     public static Path getQrCodePath(Person person) {
-        return Paths.get(QR_CODE_FOLDER.toString(),
-                person.getName().toString() + "_" + person.getPhone().toString() + ".png");
+        return Paths.get(QR_CODE_FOLDER.toString(), person.hashCode() + ".png");
     }
 }

src/test/java/seedu/address/QrCodeGeneratorTest.java

@@ -25,8 +25,7 @@ void generateQrCode_validPerson_success() throws IOException, WriterException {
     @Test
     void getQrCodePath_validPerson_success() {
         Path path = QrCodeGenerator.getQrCodePath(ALICE);
-        String expected = Paths.get(QrCodeGenerator.QR_CODE_FOLDER.toString(),
-                ALICE.getName().toString() + "_" + ALICE.getPhone().toString() + ".png").toString();
+        String expected = Paths.get(QrCodeGenerator.QR_CODE_FOLDER.toString(), ALICE.hashCode() + ".png").toString();
         assertEquals(expected, path.toString());
     }
 }