Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add contacts #30

Merged
merged 14 commits into from
Mar 12, 2024
Merged

Conversation

martinng01
Copy link

No description provided.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 81.92090% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 68.69%. Comparing base (8473993) to head (66c9fc6).

Files Patch % Lines
...java/seedu/address/logic/commands/EditCommand.java 0.00% 14 Missing ⚠️
...c/main/java/seedu/address/model/person/Person.java 76.92% 1 Missing and 5 partials ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 3 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 86.66% 1 Missing and 1 partial ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 50.00% 2 Missing ⚠️
.../seedu/address/logic/parser/EditCommandParser.java 0.00% 1 Missing ⚠️
...n/java/seedu/address/model/person/BankDetails.java 92.85% 1 Missing ⚠️
...ava/seedu/address/model/person/EmploymentType.java 92.85% 1 Missing ⚠️
src/main/java/seedu/address/model/person/Name.java 75.00% 1 Missing ⚠️
src/main/java/seedu/address/model/person/Sex.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             add-delete      #30      +/-   ##
================================================
- Coverage         75.26%   68.69%   -6.57%     
+ Complexity          419      414       -5     
================================================
  Files                71       74       +3     
  Lines              1338     1415      +77     
  Branches            126      135       +9     
================================================
- Hits               1007      972      -35     
- Misses              301      408     +107     
- Partials             30       35       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxunze jxunze merged commit d8a3fe5 into AY2324S2-CS2103T-T17-4:add-delete Mar 12, 2024
8 of 10 checks passed
@huekoh huekoh requested a review from jxunze March 12, 2024 07:46
@huekoh huekoh added this to the v1.2 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants