Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete function #45

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Conversation

jxunze
Copy link

@jxunze jxunze commented Mar 17, 2024

Edited the command function to index off phone number.
Screenshot 2024-03-17 at 4 10 31 PM

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (d8ede6c) to head (b6c2f61).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
+ Coverage     72.32%   72.44%   +0.12%     
- Complexity      451      453       +2     
============================================
  Files            77       77              
  Lines          1568     1575       +7     
  Branches        161      163       +2     
============================================
+ Hits           1134     1141       +7     
  Misses          391      391              
  Partials         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -50,7 +50,7 @@ You can reach us at the email `seer[at]comp.nus.edu.sg`
* Role: Developer
* Responsibilities: Testing

### James Doe
### Jin Xunze
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi James Doe

exists = true;
personToDelete = person;
break;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra empty line here

Copy link

@1rbg 1rbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Xunze👍

@jxunze jxunze merged commit 915ff34 into AY2324S2-CS2103T-T17-4:master Mar 17, 2024
5 checks passed
@jxunze jxunze modified the milestones: v1.1, v1.2 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants