-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete function #45
Delete function #45
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
============================================
+ Coverage 72.32% 72.44% +0.12%
- Complexity 451 453 +2
============================================
Files 77 77
Lines 1568 1575 +7
Branches 161 163 +2
============================================
+ Hits 1134 1141 +7
Misses 391 391
Partials 43 43 ☔ View full report in Codecov by Sentry. |
@@ -50,7 +50,7 @@ You can reach us at the email `seer[at]comp.nus.edu.sg` | |||
* Role: Developer | |||
* Responsibilities: Testing | |||
|
|||
### James Doe | |||
### Jin Xunze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi James Doe
exists = true; | ||
personToDelete = person; | ||
break; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra empty line here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks Xunze👍
Edited the command function to index off phone number.
![Screenshot 2024-03-17 at 4 10 31 PM](https://private-user-images.githubusercontent.com/93668030/313455445-5507b1bf-09f6-428b-8a56-337eaa8ab848.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDE3OTgsIm5iZiI6MTczOTIwMTQ5OCwicGF0aCI6Ii85MzY2ODAzMC8zMTM0NTU0NDUtNTUwN2IxYmYtMDlmNi00MjhiLThhNTYtMzM3ZWFhOGFiODQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE1MzEzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY5MDliOGEwYWM4MWIzOWFjZGE0MzlhZWEzZDRhY2NjZTAxODMxYjY0ZGNlYTIzMWE4MzZkOWQ5MTQyYjA4ZTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.1r3ucnpJhx5hZr5Njc72SzzfdPp65MkXLDsRDmG7NBs)