Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.2 Edit Command Tests #46

Merged
merged 5 commits into from
Mar 17, 2024
Merged

V1.2 Edit Command Tests #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9097007
Change tags to fit target audience
1rbg Mar 17, 2024
6e9f667
Change tags to fit target audience
1rbg Mar 17, 2024
2cfde0a
Edit test cases for new model parameters
1rbg Mar 17, 2024
1bf5f8a
Merge branch 'master' into v1.2-EditCommandTests
1rbg Mar 17, 2024
c6a3fe2
Add hours worked to toString() check
1rbg Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/test/java/seedu/address/logic/commands/CommandTestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ public class CommandTestUtil {
public static final String VALID_ADDRESS_BOB = "Block 123, Bobby Street 3";
public static final String VALID_BANKDETAILS_AMY = "8374219837";
public static final String VALID_BANKDETAILS_BOB = "3214213212";
public static final String VALID_TAG_WAITER = "waiter";
public static final String VALID_TAG_COOK = "cook";
public static final int VALID_WORK_HOURS_AMY = 10;
public static final int VALID_WORK_HOURS_BOB = 20;
public static final String VALID_TAG_HUSBAND = "husband";
public static final String VALID_TAG_FRIEND = "friend";

public static final String FIRSTNAME_DESC_AMY = " " + PREFIX_FIRSTNAME + VALID_FIRSTNAME_AMY;
public static final String LASTNAME_DESC_AMY = " " + PREFIX_LASTNAME + VALID_LASTNAME_AMY;
Expand All @@ -63,8 +63,8 @@ public class CommandTestUtil {
public static final String BANKDETAILS_DESC_AMY = " " + PREFIX_BANKDETAILS + VALID_BANKDETAILS_AMY;
public static final String BANKDETAILS_DESC_BOB = " " + PREFIX_BANKDETAILS + VALID_BANKDETAILS_BOB;

public static final String TAG_DESC_FRIEND = " " + PREFIX_TAG + VALID_TAG_FRIEND;
public static final String TAG_DESC_HUSBAND = " " + PREFIX_TAG + VALID_TAG_HUSBAND;
public static final String TAG_DESC_COOK = " " + PREFIX_TAG + VALID_TAG_COOK;
public static final String TAG_DESC_WAITER = " " + PREFIX_TAG + VALID_TAG_WAITER;

public static final String INVALID_FIRSTNAME_DESC = " " + PREFIX_FIRSTNAME + "James&"; // '&' not allowed in
public static final String INVALID_LASTNAME_DESC = " " + PREFIX_LASTNAME + "Char.les"; // '&' not allowed in
Expand All @@ -88,10 +88,10 @@ public class CommandTestUtil {
static {
DESC_AMY = new EditPersonDescriptorBuilder().withFirstName(VALID_FIRSTNAME_AMY)
.withPhone(VALID_PHONE_AMY)
.withTags(VALID_TAG_FRIEND).build();
.withTags(VALID_TAG_COOK).build();
DESC_BOB = new EditPersonDescriptorBuilder().withFirstName(VALID_LASTNAME_BOB)
.withPhone(VALID_PHONE_BOB)
.withTags(VALID_TAG_HUSBAND, VALID_TAG_FRIEND).build();
.withTags(VALID_TAG_WAITER, VALID_TAG_COOK).build();
}

/**
Expand Down
388 changes: 202 additions & 186 deletions src/test/java/seedu/address/logic/commands/EditCommandTest.java
View file
Open in desktop

Large diffs are not rendered by default.

143 changes: 72 additions & 71 deletions src/test/java/seedu/address/logic/commands/EditPersonDescriptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,71 +1,72 @@
//package seedu.address.logic.commands;
//
//import static org.junit.jupiter.api.Assertions.assertEquals;
//import static org.junit.jupiter.api.Assertions.assertFalse;
//import static org.junit.jupiter.api.Assertions.assertTrue;
//import static seedu.address.logic.commands.CommandTestUtil.DESC_AMY;
//import static seedu.address.logic.commands.CommandTestUtil.DESC_BOB;
//import static seedu.address.logic.commands.CommandTestUtil.VALID_ADDRESS_BOB;
//import static seedu.address.logic.commands.CommandTestUtil.VALID_EMAIL_BOB;
//import static seedu.address.logic.commands.CommandTestUtil.VALID_NAME_BOB;
//import static seedu.address.logic.commands.CommandTestUtil.VALID_PHONE_BOB;
//import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_HUSBAND;
//
//import org.junit.jupiter.api.Test;
//
//import seedu.address.logic.commands.EditCommand.EditPersonDescriptor;
//import seedu.address.testutil.EditPersonDescriptorBuilder;
//
//public class EditPersonDescriptorTest {
//
// @Test
// public void equals() {
// // same values -> returns true
// EditPersonDescriptor descriptorWithSameValues = new EditPersonDescriptor(DESC_AMY);
// assertTrue(DESC_AMY.equals(descriptorWithSameValues));
//
// // same object -> returns true
// assertTrue(DESC_AMY.equals(DESC_AMY));
//
// // null -> returns false
// assertFalse(DESC_AMY.equals(null));
//
// // different types -> returns false
// assertFalse(DESC_AMY.equals(5));
//
// // different values -> returns false
// assertFalse(DESC_AMY.equals(DESC_BOB));
//
// // different name -> returns false
// EditPersonDescriptor editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withName(VALID_NAME_BOB).build();
// assertFalse(DESC_AMY.equals(editedAmy));
//
// // different phone -> returns false
// editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withPhone(VALID_PHONE_BOB).build();
// assertFalse(DESC_AMY.equals(editedAmy));
//
// // different email -> returns false
// editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withEmail(VALID_EMAIL_BOB).build();
// assertFalse(DESC_AMY.equals(editedAmy));
//
// // different address -> returns false
// editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withAddress(VALID_ADDRESS_BOB).build();
// assertFalse(DESC_AMY.equals(editedAmy));
//
// // different tags -> returns false
// editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withTags(VALID_TAG_HUSBAND).build();
// assertFalse(DESC_AMY.equals(editedAmy));
// }
//
// @Test
// public void toStringMethod() {
// EditPersonDescriptor editPersonDescriptor = new EditPersonDescriptor();
// String expected = EditPersonDescriptor.class.getCanonicalName() + "{name="
// + editPersonDescriptor.getName().orElse(null) + ", phone="
// + editPersonDescriptor.getPhone().orElse(null) + ", email="
// + editPersonDescriptor.getEmail().orElse(null) + ", address="
// + editPersonDescriptor.getAddress().orElse(null) + ", tags="
// + editPersonDescriptor.getTags().orElse(null) + "}";
// assertEquals(expected, editPersonDescriptor.toString());
// }
//}
package seedu.address.logic.commands;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static seedu.address.logic.commands.CommandTestUtil.DESC_AMY;
import static seedu.address.logic.commands.CommandTestUtil.DESC_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_ADDRESS_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_FIRSTNAME_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_LASTNAME_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_PHONE_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_WAITER;

import org.junit.jupiter.api.Test;

import seedu.address.logic.commands.EditCommand.EditPersonDescriptor;
import seedu.address.testutil.EditPersonDescriptorBuilder;

public class EditPersonDescriptorTest {

@Test
public void equals() {
// same values -> returns true
EditPersonDescriptor descriptorWithSameValues = new EditPersonDescriptor(DESC_AMY);
assertTrue(DESC_AMY.equals(descriptorWithSameValues));

// same object -> returns true
assertTrue(DESC_AMY.equals(DESC_AMY));

// null -> returns false
assertFalse(DESC_AMY.equals(null));

// different types -> returns false
assertFalse(DESC_AMY.equals(5));

// different values -> returns false
assertFalse(DESC_AMY.equals(DESC_BOB));

// different name -> returns false
EditPersonDescriptor editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withFirstName(VALID_FIRSTNAME_BOB)
.withLastName(VALID_LASTNAME_BOB).build();
assertFalse(DESC_AMY.equals(editedAmy));

// different phone -> returns false
editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withPhone(VALID_PHONE_BOB).build();
assertFalse(DESC_AMY.equals(editedAmy));

// different address -> returns false
editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withAddress(VALID_ADDRESS_BOB).build();
assertFalse(DESC_AMY.equals(editedAmy));

// different tags -> returns false
editedAmy = new EditPersonDescriptorBuilder(DESC_AMY).withTags(VALID_TAG_WAITER).build();
assertFalse(DESC_AMY.equals(editedAmy));
}

@Test
public void toStringMethod() {
EditPersonDescriptor editPersonDescriptor = new EditPersonDescriptor();
String expected = EditPersonDescriptor.class.getCanonicalName() + "{firstName="
+ editPersonDescriptor.getFirstName().orElse(null) + ", lastName="
+ editPersonDescriptor.getLastName().orElse(null) + ", phone="
+ editPersonDescriptor.getPhone().orElse(null) + ", sex="
+ editPersonDescriptor.getSex().orElse(null) + ", employmentType="
+ editPersonDescriptor.getEmploymentType().orElse(null) + ", address="
+ editPersonDescriptor.getAddress().orElse(null) + ", bankDetails="
+ editPersonDescriptor.getBankDetails().orElse(null) + ", hoursWorked="
+ editPersonDescriptor.getHoursWorked().orElse(null) + ", tags="
+ editPersonDescriptor.getTags().orElse(null) + "}";
assertEquals(expected, editPersonDescriptor.toString());
}
}
32 changes: 16 additions & 16 deletions src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@
import static seedu.address.logic.commands.CommandTestUtil.PREAMBLE_WHITESPACE;
import static seedu.address.logic.commands.CommandTestUtil.SEX_DESC_AMY;
import static seedu.address.logic.commands.CommandTestUtil.SEX_DESC_BOB;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_FRIEND;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_HUSBAND;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_COOK;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_WAITER;
import static seedu.address.logic.commands.CommandTestUtil.VALID_ADDRESS_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_EMPLOYMENTTYPE_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_FIRSTNAME_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_LASTNAME_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_PHONE_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_SEX_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_FRIEND;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_HUSBAND;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_COOK;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_WAITER;
import static seedu.address.logic.parser.CliSyntax.PREFIX_ADDRESS;
import static seedu.address.logic.parser.CliSyntax.PREFIX_BANKDETAILS;
import static seedu.address.logic.parser.CliSyntax.PREFIX_EMPLOYMENTTYPE;
Expand Down Expand Up @@ -64,29 +64,29 @@ public class AddCommandParserTest {

@Test
public void parse_allFieldsPresent_success() {
Person expectedPerson = new PersonBuilder(BOB).withTags(VALID_TAG_FRIEND).build();
Person expectedPerson = new PersonBuilder(BOB).withTags(VALID_TAG_COOK).build();

// whitespace only preamble
assertParseSuccess(parser, PREAMBLE_WHITESPACE + FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB + PHONE_DESC_BOB
+ SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB + BANKDETAILS_DESC_BOB + ADDRESS_DESC_BOB + TAG_DESC_FRIEND,
+ SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB + BANKDETAILS_DESC_BOB + ADDRESS_DESC_BOB + TAG_DESC_COOK,
new AddCommand(expectedPerson));


// multiple tags - all accepted
Person expectedPersonMultipleTags = new PersonBuilder(BOB).withTags(VALID_TAG_FRIEND, VALID_TAG_HUSBAND)
Person expectedPersonMultipleTags = new PersonBuilder(BOB).withTags(VALID_TAG_COOK, VALID_TAG_WAITER)
.build();
assertParseSuccess(parser,
FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB + PHONE_DESC_BOB + SEX_DESC_BOB
+ EMPLOYMENTTYPE_DESC_BOB + ADDRESS_DESC_BOB
+ BANKDETAILS_DESC_BOB + TAG_DESC_HUSBAND + TAG_DESC_FRIEND,
+ BANKDETAILS_DESC_BOB + TAG_DESC_WAITER + TAG_DESC_COOK,
new AddCommand(expectedPersonMultipleTags));
}

@Test
public void parse_repeatedNonTagValue_failure() {
String validExpectedPersonString = FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB
+ PHONE_DESC_BOB + SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB
+ ADDRESS_DESC_BOB + BANKDETAILS_DESC_BOB + TAG_DESC_FRIEND;
+ ADDRESS_DESC_BOB + BANKDETAILS_DESC_BOB + TAG_DESC_COOK;

// multiple first names
assertParseFailure(parser, FIRSTNAME_DESC_AMY + validExpectedPersonString,
Expand Down Expand Up @@ -198,32 +198,32 @@ public void parse_invalidValue_failure() {
// invalid name
assertParseFailure(parser, INVALID_FIRSTNAME_DESC + LASTNAME_DESC_BOB + PHONE_DESC_BOB
+ SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB + ADDRESS_DESC_BOB
+ TAG_DESC_HUSBAND + TAG_DESC_FRIEND, Name.MESSAGE_CONSTRAINTS);
+ TAG_DESC_WAITER + TAG_DESC_COOK, Name.MESSAGE_CONSTRAINTS);

// invalid name
assertParseFailure(parser, FIRSTNAME_DESC_BOB + INVALID_LASTNAME_DESC + PHONE_DESC_BOB
+ SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB + ADDRESS_DESC_BOB
+ TAG_DESC_HUSBAND + TAG_DESC_FRIEND, Name.MESSAGE_CONSTRAINTS);
+ TAG_DESC_WAITER + TAG_DESC_COOK, Name.MESSAGE_CONSTRAINTS);

// invalid phone
assertParseFailure(parser, FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB + INVALID_PHONE_DESC
+ SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB + ADDRESS_DESC_BOB
+ TAG_DESC_HUSBAND + TAG_DESC_FRIEND, Phone.MESSAGE_CONSTRAINTS);
+ TAG_DESC_WAITER + TAG_DESC_COOK, Phone.MESSAGE_CONSTRAINTS);

// invalid sex
assertParseFailure(parser, FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB + PHONE_DESC_BOB
+ INVALID_SEX_DESC + EMPLOYMENTTYPE_DESC_BOB + ADDRESS_DESC_BOB
+ TAG_DESC_HUSBAND + TAG_DESC_FRIEND, Sex.MESSAGE_CONSTRAINTS);
+ TAG_DESC_WAITER + TAG_DESC_COOK, Sex.MESSAGE_CONSTRAINTS);

// invalid employment type
assertParseFailure(parser, FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB + PHONE_DESC_BOB
+ SEX_DESC_BOB + INVALID_EMPLOYMENTTYPE_DESC + ADDRESS_DESC_BOB
+ TAG_DESC_HUSBAND + TAG_DESC_FRIEND, EmploymentType.MESSAGE_CONSTRAINTS);
+ TAG_DESC_WAITER + TAG_DESC_COOK, EmploymentType.MESSAGE_CONSTRAINTS);

// invalid tag
assertParseFailure(parser, FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB + PHONE_DESC_BOB
+ SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB + ADDRESS_DESC_BOB
+ INVALID_TAG_DESC + VALID_TAG_FRIEND, Tag.MESSAGE_CONSTRAINTS);
+ INVALID_TAG_DESC + VALID_TAG_COOK, Tag.MESSAGE_CONSTRAINTS);

// two invalid values, only first invalid value reported
assertParseFailure(parser, INVALID_FIRSTNAME_DESC + LASTNAME_DESC_BOB + PHONE_DESC_BOB
Expand All @@ -233,7 +233,7 @@ public void parse_invalidValue_failure() {
// non-empty preamble
assertParseFailure(parser, PREAMBLE_NON_EMPTY + FIRSTNAME_DESC_BOB + LASTNAME_DESC_BOB
+ PHONE_DESC_BOB + SEX_DESC_BOB + EMPLOYMENTTYPE_DESC_BOB
+ ADDRESS_DESC_BOB + TAG_DESC_HUSBAND + TAG_DESC_FRIEND,
+ ADDRESS_DESC_BOB + TAG_DESC_WAITER + TAG_DESC_COOK,
String.format(MESSAGE_INVALID_COMMAND_FORMAT, AddCommand.MESSAGE_USAGE));
}
}
28 changes: 14 additions & 14 deletions src/test/java/seedu/address/logic/parser/EditCommandParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@
import static seedu.address.logic.commands.CommandTestUtil.LASTNAME_DESC_AMY;
import static seedu.address.logic.commands.CommandTestUtil.PHONE_DESC_AMY;
import static seedu.address.logic.commands.CommandTestUtil.PHONE_DESC_BOB;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_FRIEND;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_HUSBAND;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_COOK;
import static seedu.address.logic.commands.CommandTestUtil.TAG_DESC_WAITER;
import static seedu.address.logic.commands.CommandTestUtil.VALID_ADDRESS_AMY;
import static seedu.address.logic.commands.CommandTestUtil.VALID_EMPLOYMENTTYPE_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_FIRSTNAME_AMY;
import static seedu.address.logic.commands.CommandTestUtil.VALID_LASTNAME_AMY;
import static seedu.address.logic.commands.CommandTestUtil.VALID_PHONE_AMY;
import static seedu.address.logic.commands.CommandTestUtil.VALID_PHONE_BOB;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_FRIEND;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_HUSBAND;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_COOK;
import static seedu.address.logic.commands.CommandTestUtil.VALID_TAG_WAITER;
import static seedu.address.logic.parser.CliSyntax.PREFIX_ADDRESS;
import static seedu.address.logic.parser.CliSyntax.PREFIX_PHONE;
import static seedu.address.logic.parser.CliSyntax.PREFIX_TAG;
Expand Down Expand Up @@ -100,11 +100,11 @@ public void parse_invalidValue_failure() {

// while parsing {@code PREFIX_TAG} alone will reset the tags of the {@code Person} being edited,
// parsing it together with a valid tag results in error
assertParseFailure(parser, VALID_PHONE_AMY + TAG_DESC_FRIEND + TAG_DESC_HUSBAND + TAG_EMPTY,
assertParseFailure(parser, VALID_PHONE_AMY + TAG_DESC_COOK + TAG_DESC_WAITER + TAG_EMPTY,
Tag.MESSAGE_CONSTRAINTS);
assertParseFailure(parser, VALID_PHONE_AMY + TAG_DESC_FRIEND + TAG_EMPTY + TAG_DESC_HUSBAND,
assertParseFailure(parser, VALID_PHONE_AMY + TAG_DESC_COOK + TAG_EMPTY + TAG_DESC_WAITER,
Tag.MESSAGE_CONSTRAINTS);
assertParseFailure(parser, VALID_PHONE_AMY + TAG_EMPTY + TAG_DESC_FRIEND + TAG_DESC_HUSBAND,
assertParseFailure(parser, VALID_PHONE_AMY + TAG_EMPTY + TAG_DESC_COOK + TAG_DESC_WAITER,
Tag.MESSAGE_CONSTRAINTS);
// multiple invalid values, but only the first invalid value is captured
assertParseFailure(parser, VALID_PHONE_AMY + INVALID_FIRSTNAME_DESC + INVALID_EMPLOYMENTTYPE_DESC
Expand All @@ -114,12 +114,12 @@ public void parse_invalidValue_failure() {
@Test
public void parse_allFieldsSpecified_success() {
Phone targetPhone = new Phone(VALID_PHONE_AMY);
String userInput = VALID_PHONE_AMY + PHONE_DESC_AMY + TAG_DESC_HUSBAND
+ ADDRESS_DESC_AMY + FIRSTNAME_DESC_AMY + TAG_DESC_FRIEND + LASTNAME_DESC_AMY;
String userInput = VALID_PHONE_AMY + PHONE_DESC_AMY + TAG_DESC_WAITER
+ ADDRESS_DESC_AMY + FIRSTNAME_DESC_AMY + TAG_DESC_COOK + LASTNAME_DESC_AMY;

EditPersonDescriptor descriptor = new EditPersonDescriptorBuilder().withFirstName(VALID_FIRSTNAME_AMY)
.withLastName(VALID_LASTNAME_AMY).withPhone(VALID_PHONE_AMY)
.withAddress(VALID_ADDRESS_AMY).withTags(VALID_TAG_HUSBAND, VALID_TAG_FRIEND).build();
.withAddress(VALID_ADDRESS_AMY).withTags(VALID_TAG_WAITER, VALID_TAG_COOK).build();
EditCommand expectedCommand = new EditCommand(targetPhone, descriptor);

assertParseSuccess(parser, userInput, expectedCommand);
Expand Down Expand Up @@ -153,8 +153,8 @@ public void parse_oneFieldSpecified_success() {
assertParseSuccess(parser, userInput, expectedCommand);

// tags
userInput = VALID_PHONE_AMY + TAG_DESC_FRIEND;
descriptor = new EditPersonDescriptorBuilder().withTags(VALID_TAG_FRIEND).build();
userInput = VALID_PHONE_AMY + TAG_DESC_COOK;
descriptor = new EditPersonDescriptorBuilder().withTags(VALID_TAG_COOK).build();
expectedCommand = new EditCommand(targetPhone, descriptor);
assertParseSuccess(parser, userInput, expectedCommand);

Expand Down Expand Up @@ -183,8 +183,8 @@ public void parse_multipleRepeatedFields_failure() {

// mulltiple valid fields repeated
userInput = targetPhone + PHONE_DESC_AMY + ADDRESS_DESC_AMY
+ TAG_DESC_FRIEND + PHONE_DESC_AMY + ADDRESS_DESC_AMY + TAG_DESC_FRIEND
+ PHONE_DESC_BOB + ADDRESS_DESC_BOB + TAG_DESC_HUSBAND;
+ TAG_DESC_COOK + PHONE_DESC_AMY + ADDRESS_DESC_AMY + TAG_DESC_COOK
+ PHONE_DESC_BOB + ADDRESS_DESC_BOB + TAG_DESC_WAITER;

assertParseFailure(parser, userInput,
Messages.getErrorMessageForDuplicatePrefixes(PREFIX_PHONE, PREFIX_ADDRESS));
Expand Down
Loading
Loading