Skip to content

Commit

Permalink
Update planned enhancements and fix search command uml diagram
Browse files Browse the repository at this point in the history
  • Loading branch information
logical-1985516 committed Apr 14, 2024
1 parent aab08c0 commit 71671c4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -1023,3 +1023,4 @@ Hirehub data is saved locally in three separate files `addressbook.json`, `appli
6. Currently, we can add duplicate tags to a candidate without any errors, and only one of the duplicate tags would be added to the candidate. We intend to add a message informing the user that they are adding duplicate tags.
7. Currently, tags only support alphanumeric characters, which means that whitespaces are not supported. We intend to support tags with multiple words by relaxing the constraints of the tag to allow for whitespaces.
8. Currently, the UI does not support wrapping of tags. We intend to fix this in the future to allow users to view tags with long names.
9. Currently, Hirehub will throw a Null Pointer Exception if there is null in the tag list of a candidate (done via editing addressbook.json). We intend to fix this, by not only allowing Hirehub to launch (with a new empty addressbook.json) in such cases, but also inform the user that the json file is corrupted.
3 changes: 1 addition & 2 deletions docs/diagrams/SearchSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ deactivate SearchPersonDescriptor

create SearchCommand
SearchCommandParser -> SearchCommand
activate SearchCommandCommand

activate SearchCommand

SearchCommand --> SearchCommandParser
deactivate SearchCommand
Expand Down
Binary file modified docs/images/SearchSequenceDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 71671c4

Please sign in to comment.