Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow edit command to delete optional fields #154

Conversation

AbdulrahmanAlRammah
Copy link
Collaborator

@AbdulrahmanAlRammah AbdulrahmanAlRammah commented Oct 28, 2024

  • Allow deletion of optional fields by edit command
  • Update the Testing to match the new functionality
  • Update the UG to explain changes

This PR enables users to delete optional fields when editing by entering the prefix without any value.
The add command can now accept entries such as (Add n/John p/12345678 e/) where e/ would just indicate the person doesn't want to input an email. This is worth noting but likely the person won't bother to write the e/ anyways.

Closes #144

@AbdulrahmanAlRammah AbdulrahmanAlRammah added this to the v1.5 milestone Oct 28, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 94.44% <100.00%> (-3.71%) 25.00 <0.00> (+3.00) ⬇️

... and 1 file with indirect coverage changes

Copy link

@liauzhanyi liauzhanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@liauzhanyi liauzhanyi merged commit 4de1c6c into AY2425S1-CS2103-F10-2:master Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Edit to delete optional fields
2 participants