Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable text wrapping for names #170

Merged

Conversation

Andrew22Teoh
Copy link
Collaborator

@Andrew22Teoh Andrew22Teoh commented Oct 31, 2024

This is a simple fix, just enabled text wrapping so that long names are still visible.
image

Not done for phone number, date of last visit, or emergency contact since those fields will never be long.

In the full person view card, address, email, and remarks also have wrap text enabled, since those can be long.

Closes #145

@Andrew22Teoh Andrew22Teoh added this to the v1.5 milestone Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@Andrew22Teoh Andrew22Teoh added the type.Chore Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Nov 2, 2024
@Andrew22Teoh Andrew22Teoh marked this pull request as ready for review November 2, 2024 01:44
Copy link

@Rachael-Chan Rachael-Chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachael-Chan Rachael-Chan merged commit 76a9693 into AY2425S1-CS2103-F10-2:master Nov 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha-bug type.Chore Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle non-readability of very long names
2 participants