Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity for SortCommand format #211

Merged

Conversation

AbdulrahmanAlRammah
Copy link
Collaborator

Nit changes

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/SortCommand.java 82.35% <ø> (ø) 10.00 <0.00> (ø)

@AbdulrahmanAlRammah AbdulrahmanAlRammah marked this pull request as ready for review November 7, 2024 11:09
@AbdulrahmanAlRammah AbdulrahmanAlRammah added this to the v1.5 milestone Nov 7, 2024
@@ -189,7 +189,7 @@ Examples:

Sorts the list of persons being viewed by name or date of last visit in ascending or descending order.

Format: `sort PARAMETER/ORDER`
Format: `sort PARAMETER PREFIX/ORDER`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would be better to use PARAMETER_PREFIX/ORDER instead to indicate it is 1 placeholder instead of 2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for the subsequent lines

Copy link

@liauzhanyi liauzhanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@liauzhanyi liauzhanyi merged commit 8c6117a into AY2425S1-CS2103-F10-2:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants