-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintaining Sort order when adding or editing contacts #213
Maintaining Sort order when adding or editing contacts #213
Conversation
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some naming issues to fix, otherwise I think great idea to make use of the preferences.json
!
@@ -20,6 +22,8 @@ | |||
*/ | |||
public class ModelManager implements Model { | |||
private static final Logger logger = LogsCenter.getLogger(ModelManager.class); | |||
private static final String RESORT_ERROR = "Error: User Prefs had an invalid sort parameter. " | |||
+ "Resorting after changes were made to the addressbook was abandoned."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think should be "Re-sorting"?
setSortSettings(new SortSettings(parameter, isAscending)); | ||
} | ||
|
||
private void resortPersonList(SortSettings sortSettings) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if its just me but since "resort" is an actual word, it kind of requires at least a second read in order to understand what it meant. I think maybe sortPersonListAgain
might be better? or if you prefer re-sort then reSortPersonList
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #175