Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example for sort error message not on new line #217

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Example for sort error message not on new line #217

merged 1 commit into from
Nov 7, 2024

Conversation

rayray39
Copy link

@rayray39 rayray39 commented Nov 7, 2024

closes #216

@rayray39 rayray39 added this to the v1.5 milestone Nov 7, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/SortCommand.java 82.35% <ø> (ø) 10.00 <0.00> (ø)

AbdulrahmanAlRammah
AbdulrahmanAlRammah approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@AbdulrahmanAlRammah AbdulrahmanAlRammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AbdulrahmanAlRammah AbdulrahmanAlRammah merged commit 7be2f77 into AY2425S1-CS2103-F10-2:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdulrahmanAlRammah AbdulrahmanAlRammah AbdulrahmanAlRammah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Example for sort error message not new line
2 participants
@rayray39 @AbdulrahmanAlRammah