Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PED Bugs Issues 240 - 256 Improvements #308

Merged
merged 22 commits into from
Nov 12, 2024

Conversation

AbdulrahmanAlRammah
Copy link
Collaborator

@AbdulrahmanAlRammah AbdulrahmanAlRammah commented Nov 11, 2024

This PR is for updating information associated to the issues 240 - 256 from PED.

Closes #242
Since its a UG talking about project objectives doesn't make sense. However, I add lines in the beginning to explain how social book benefits our target user (social worker in Singapore).

Closes #244
Clarified that seed command doesn't inform the user on duplicate skipping in UG.

Closes #246
Mentioned in planned enhancements.

Closes #249
I explained the general sort order. I didn't mention ASCII because most users won't know it.

Closes #254
Moved the contact fields requirements up as this order makes more sense.

Closes #256
Added Planned enhancements appendix and mentioned improving the list error message to make it more helpful.

Closes #288 #302

@AbdulrahmanAlRammah AbdulrahmanAlRammah added this to the v1.6 milestone Nov 11, 2024
@AbdulrahmanAlRammah AbdulrahmanAlRammah self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@AbdulrahmanAlRammah AbdulrahmanAlRammah marked this pull request as ready for review November 11, 2024 14:29
Comment on lines 292 to 327
| Priority | As a …​ | I want to …​ | So that I can…​ |
|----------|--------------------------------------------|----------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------|
| `* * *` | social worker | delete a contact | remove the contact when I no longer serve them so that the contact list does not get too long |
| `* * *` | social worker/new user | add contact with phone number | remember the person I serve |
| `* * *` | social worker/new user | add address | easily look up without needed to look up database/files |
| `* * *` | social worker | view my list of contacts | see the beneficiaries I serve |
| `* *` | overwhelmed with many households | take note of how long it has been since I visited each house | ensure that no house gets forgotten in my scheduling |
| `* *` | new user learning the interface | check out basic commands that are frequently used with a help command | learn the basic usage of the program more quickly |
| `* *` | user with multiple contacts per household | tag multiple users to be from the same household | simplify the process of contacting other household members |
| `* *` | social worker | prioritize contacts | allow myself to have quick access to high priority household |
| `* *` | social worker | add alternative contact method | add a contact for elderly who do not have a phone |
| `* *` | social worker/expert user | look for emergency contact quickly | inform next-of-kin when something happen |
| `* *` | social worker/expert user | add family contact | know how many people in the household |
| `* *` | social worker/expert user | add notes | remember if I need to take precaution before visiting the person/family or preparations i need to make |
| `* *` | social worker/expert user | sort contacts by lexicographical order | find contact quickly if I remember the name |
| `* *` | social worker/expert user | search through contacts using keywords | find contact quickly based on key words within the contact information |
| `* *` | social worker/expert user | add alternative phone number | have another way of reaching the beneficiary |
| `* *` | social worker/new user | edit contact | edit the contact without the need to delete and create a new one |
| `* *` | forgetful individual | add tags which explain what service the person needs | remember and be able to meet the needs of beneficiaries |
| `* *` | holder of sensitive information | lock the SocialBook behind a password | avoid having unsolicited sharing of personal information |
| `* *` | max/expert user | add the medicinal information of beneficiaries | to know when to follow up on critical medicines |
| `* *` | new user | see a sample of the product features on display | so that I know how a feature can be used to maximise the value |
| `*` | has rotating beneficiaries | remove several contacts at once, when beneficiaries no longer require care | so that I can make space for new beneficiaries and not keep track of old ones |
| `*` | max/expert user | know the households I need to visit on a certain day | so that I can schedule my day and not forget to visit any households |
| `*` | user short on time | visit households that are geographically close in the same day/visit | minimise the travelling time for myself |
| `*` | user switching devices | transfer the SocialBook contacts from one device to another | avoid having to manually re-enter all the current contacts |
| `*` | max/expert user | export all contacts to a txt file/excel file | so that I have a copy of all beneficiaries, past and present, in a larger database |
| `*` | max/expert user | record social media credentials of a contact, if they have any | so that I can get to know their lives better and establish a closer bond |
| `*` | max/expert user | send reminder to my email a day before my visit | so that I will not forget to visit a household |
| `*` | max/expert user | upload pictures of my beneficiaries | so that I will not forget how they look like |
| `*` | max/expert user | view contacts on google maps | so that I can directly see where and how to go to the household |
| `*` | visual rememberer | add photos for each contact | to match beneficiary names to their faces more easily |
| `*` | loyal user | save contact information into a shareable form | share contacts with colleagues as need be |
| `*` | experienced social worker | locate a link where I can share my views and suggestions on the app | help the app be more user centered and helpful over time |
| `*` | efficient person | create visit paths based on proximity of beneficiaries | to be able to serve the most beneficiaries a day |
| `*` | social person | add notes of on conversations with beneficiaries | develop stronger relationships by building rapport |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about the suggestion i made under issue #305

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I think we should just stick to this. Not much of a difference and I believe the "so that I can is what was taught in class".


## **Appendix: Planned Enhancements**

1. Make list command with miscellaneous parameters error message more helpful. Currently, typing list with miscellaneous parameters, ex. `list 123`, will result in a message that states "Please ensure your command is valid!". To improve specificity this will be changed to ask user to remove miscellaneous parameters.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it would be nice to wrap list in backticks


### Date of Last Visit
* Dates of last visit are optional for contacts, and are denoted by the `d/` prefix.
* Dates of last visit are confined to the `DD-MM-YYYY` format.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change this to dd-MM-yyyy like in the gui message for consistency? since we can't change what is on the app.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah can I think rayner's PR does this, but let me double check.

# Conflicts:
#	docs/DeveloperGuide.md
#	docs/UserGuide.md
# Conflicts:
#	docs/UserGuide.md
# Conflicts:
#	docs/UserGuide.md
Copy link
Collaborator

@Andrew22Teoh Andrew22Teoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Andrew22Teoh Andrew22Teoh removed the request for review from liauzhanyi November 12, 2024 02:10
@liauzhanyi liauzhanyi merged commit ce7b0b0 into AY2425S1-CS2103-F10-2:master Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment