Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle weird bugs from PeD #312

Merged
merged 6 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,14 @@ testers are expected to do more *exploratory* testing.

## **Appendix: Planned Enhancements**

For reference, our group has 5 members.

1. Make `list` command with miscellaneous parameters error message more helpful. Currently, typing `list` with miscellaneous parameters, ex. `list 123`, will result in a message that states "Please ensure your command is valid!". To improve specificity this will be changed to ask user to remove miscellaneous parameters.
2. Prevent tags from allowing underscores. When searching for tags with underscores in the find command, the underscores are interpreted as an `or`. This means that searching for the tag "low_income" will bring up all tags containing "low" and "income" instead of just "low_income".
3. Remove `remark` command while keeping remarks. Currently, remarks can be added via the edit command or the remark command but not the add command. Instead of having a dedicated remark command we will allow users to use add command to add remarks while adding a contact and edit command to add or edit the remark of a contact. This change solves an associated issue whereby the remark command currently undoes the detailed view on the contact.
3. Remove `remark` command while keeping remark fields. Currently, remarks can be added via the edit command or the remark command but not the add command. Instead of having a dedicated `remark` command, we will allow users to use the `add` command to create a contact with remarks, or the `edit` command to modify the remark of a contact. This change solves an associated issue whereby the remark command currently collapses the detailed view on the contact.
4. Restrict the validation regex for emails to require at least 2 domain labels in the domainName region of the email. Traditionally, emails require at least 2 domain labels separated by a ., but the current implementation only requires one domain label. Something like johnsmith@yahoo is accepted as an email address when it should be rejected.
5. Update the error message displayed to the user by the `edit` command upon attempt to index with 0. The current error message for `edit 0 n/Bob` states "invalid command format" when it should mention that the index provided is invalid.
6. Update the error message displayed to the user by the `remark` command upon attempt to index with 0. The current error message for `remark 0 r/Hates frisbees` states "invalid command format" when it should mention that the index provided is invalid.
7. Update the error message displayed to the user by the `delete` command upon attempt to index with 0. The current error message for `delete 0` states "invalid command format" when it should mention that the index provided is invalid.
8. Update the error message displayed to the user by the `view` command upon attempt to index with 0. The current error message for `view 0` states "invalid command format" when it should mention that the index provided is invalid.
9. Include an example of sorting by date of last visit (`d/`) in the command format message of the `sort` command.
1 change: 1 addition & 0 deletions docs/UserGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -378,3 +378,4 @@ Action | Format, Examples
**Seed** | `seed`
**Sort** | `sort PARAMETER_PREFIX/ORDER` <br> e.g., `sort n/ascending`
**Remark** | `remark INDEX r/REMARK` <br> e.g., `remark 1 r/some remark about contact`