Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify duplicate contact in User Guide #315

Merged

Conversation

liauzhanyi
Copy link

No description provided.

@liauzhanyi liauzhanyi added this to the v1.6 milestone Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

**Q3**: Why are (only) name and phone used to determine duplicate?
- To explain this, we look at the following cases and explain why they should not be considered a duplicate.
- For persons with the same name but different phone number, this is a common case.
- For persons with different name but same phone number, this is deliberate consideration we made given that in the field of social work. One example is where the beneficiaries lives in shared rental flat and people living in the same household might share the same phone number but for the social worker, he/she might want to remember each person's contact separately.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to :
For persons with different name but same phone number, this is deliberate consideration we made given that the product is designed for social workers.

Or something similar.

Copy link

@rayray39 rayray39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liauzhanyi liauzhanyi merged commit 6a6f904 into AY2425S1-CS2103-F10-2:master Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants