Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enhancements #321

Merged
merged 2 commits into from
Nov 12, 2024
+2 −1
Merged

Update enhancements #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d25899
Update enhancements
AbdulrahmanAlRammah Nov 12, 2024
1c9f7ec
Add phone number enhancement
AbdulrahmanAlRammah Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/DeveloperGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,4 +622,5 @@ For reference, our group has 5 members.
6. Update the error message displayed to the user by the `remark` command upon attempt to index with 0. The current error message for `remark 0 r/Hates frisbees` states "invalid command format" when it should mention that the index provided is invalid.
7. Update the error message displayed to the user by the `delete` command upon attempt to index with 0. The current error message for `delete 0` states "invalid command format" when it should mention that the index provided is invalid.
8. Update the error message displayed to the user by the `view` command upon attempt to index with 0. The current error message for `view 0` states "invalid command format" when it should mention that the index provided is invalid.
9. Include an example of sorting by date of last visit (`d/`) in the command format message of the `sort` command.
9. Improve clarity of phone number parsing message to give users clearer direction on the issue with the entered phone number (ex. to remove accidental extra spaces).
10. Improve clarity of emergency contact error message for invalid input. Currently, entering an invalid emergency contact will give an error message about phone numbers. This can be confusing when editing a phone number and emergency contact simultaneously. The message will be edited to more explicitly mention emergency contact and the specific issue.