Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acknowledgement section to README.md #48

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add acknowledgement section to README.md #48

merged 1 commit into from
Feb 26, 2025

Conversation

wowwwp
Copy link
Collaborator

@wowwwp wowwwp commented Feb 26, 2025

Fix #37

@wowwwp wowwwp added the type.Task Something that needs to be done, but not a story, bug, or an epic label Feb 26, 2025
@wowwwp wowwwp added this to the v1.1 milestone Feb 26, 2025
@wowwwp wowwwp requested a review from JohannsenLum February 26, 2025 03:12
@wowwwp wowwwp self-assigned this Feb 26, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

JohannsenLum
JohannsenLum approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@JohannsenLum JohannsenLum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JohannsenLum
JohannsenLum requested changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@JohannsenLum JohannsenLum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you have to update the acknowledgment into developerguide.md not readme.md but can do both

JohannsenLum
JohannsenLum approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@JohannsenLum JohannsenLum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wowwwp wowwwp merged commit 1a99121 into master Feb 26, 2025
7 checks passed
@nus-se-bot
Copy link

@wowwwp Heads up: This PR does not follow the forking workflow fully.
As following the forking workflow is a requirement for early tP iterations, this PR will not be counted when we count the 'qualifying' PRs that you contributed to the relevant tP iteration (but if merged, the code in this PR will still count as a contribution).

A gentle reminder to follow the required workflow for future tP PRs.

@wowwwp wowwwp deleted the add-acknowledgement branch February 26, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannsenLum JohannsenLum JohannsenLum approved these changes

Assignees

@wowwwp wowwwp

Labels
type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Add acknowledgement to original code
3 participants
@wowwwp @nus-se-bot @JohannsenLum