Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(nix): compatibility with NixOS 22.05 #26

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Oct 10, 2023

@blitz can you please confirm that this works with NixOS 22.05?

@mrcjkb mrcjkb force-pushed the nixos-2205-fix branch 2 times, most recently from a28ca01 to 9513728 Compare October 10, 2023 15:11
@AaronErhardt
Copy link
Owner

Just an idea, should @blitz review future PRs regarding NixOS?
I can have a rough look over the changes, but to be honest, I don't understand a lot about those NixOS configs yet.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Oct 23, 2023

Can we merge this?
This is pretty much how I did it before I packaged this for nixpkgs, so I'm pretty sure it should work 😄

@AaronErhardt AaronErhardt merged commit 90c8e8b into AaronErhardt:main Oct 23, 2023
4 checks passed
@mrcjkb mrcjkb deleted the nixos-2205-fix branch October 23, 2023 16:36
@blitz
Copy link
Contributor

blitz commented Oct 23, 2023

Ah, sorry. This notification slipped by! Looks good! (Besides the off-by-one in the year. 😄)

Feel free to tag me for reviews (or poke me on Matrix: @js:ukvly.org).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants