Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disk stats on windows #74

Closed
wants to merge 1 commit into from
Closed

Conversation

Pinguin2001
Copy link
Contributor

@Pinguin2001 Pinguin2001 commented Nov 9, 2024

Description

Fixes disk stats on windows using a simple platform check

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I ran the app myself on windows and verified functionality

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Abdenasser
Copy link
Owner

@Pinguin2001 this is being worked on at 57

@Pinguin2001
Copy link
Contributor Author

@Pinguin2001 this is being worked on at 57

Yes, however, this pr is a much simpler solution keeping the original functionality of disk filtering by mount points

@Abdenasser
Copy link
Owner

@Pinguin2001 this is being worked on at 57

Yes, however, this pr is a much simpler solution keeping the original functionality of disk filtering by mount points

yeah it's good, thank you for taking time to work on it.. but this would only display disk stats for C drive on windows

@Pinguin2001
Copy link
Contributor Author

@Pinguin2001 this is being worked on at 57

Yes, however, this pr is a much simpler solution keeping the original functionality of disk filtering by mount points

yeah it's good, thank you for taking time to work on it.. but this would only display disk stats for C drive on windows

Yes that makes more sense to have it show the disk usage for all disks

@Pinguin2001 Pinguin2001 closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants