Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark default toggler added #146

Closed

Conversation

Vipullakum007
Copy link

i have created

  1. ScrollToTopButton.js in component ( Because we need to add in every page )
  2. ScrollToTopButton.css for style the component
  3. Dark/Default Toggler in heading.js
  4. Added ScrollToTopButton in every page

Working Video

75per.mp4

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
75per ❌ Failed (Inspect) Jun 18, 2024 8:06am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Vipullakum007
Copy link
Author

hey @AbhiDiva96 , i have resolved conflict s of OLD PR. you can review it.

@Vipullakum007
Copy link
Author

NOTE : hey @AbhiDiva96 , i have made component so that anyone made change or add page then you need to add . so that added page make conflicting . i solved that please reopen the PR or i make new one.

@Vipullakum007
Copy link
Author

hey @AbhiDiva96 ,please merge ASAP because

NOTE : hey @AbhiDiva96 , i have made component so that anyone made change or add page then you need to add . so that added page make conflicting . i solved that please reopen the PR or i make new one.

@AbhiDiva96
Copy link
Owner

Your code is not clean and not actually supporting 75% design.
Someone else created a theme toggler pls check out on the site.
@Vipullakum007

@AbhiDiva96 AbhiDiva96 closed this Jun 18, 2024
@Vipullakum007
Copy link
Author

hey @AbhiDiva96 , Scroll to Top is working perfect if you want i can add that part only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants