Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syllabus for Particular Year Displayed #40

Merged
merged 1 commit into from
May 29, 2024

Conversation

swetha5157
Copy link
Contributor

Issue No:#5

Closes Issue #5

Description:
When the year is clicked followed by the Syllabus..it displays the syllabus for 8 semesters but it has to be displayed for the selected year's semester(i.e. if the 2nd year is selected, the 3rd and 4th sem has to be displayed). The issue has been resolved by providing correct routing and creating separate folders. Now the output will be when a particular year is selected then the particular semesters will be displayed for syllabus download.

My code follows the guidelines and does not produce any warnings.

Test:
I have tested with all four years and attached the video document below.

I am a GSSoC'24 Contributor.

Screenshots/Video

75.mp4

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
75per ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 5:28am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@swetha5157
Copy link
Contributor Author

Kindly check this PR @AbhiDiva96

@AbhiDiva96 AbhiDiva96 merged commit 0962dab into AbhiDiva96:main May 29, 2024
3 checks passed
@AbhiDiva96
Copy link
Owner

Screenshot 2024-05-29 204321

remove the underlines @swetha5157

@swetha5157
Copy link
Contributor Author

Shall I create as new issue @AbhiDiva96 ?

@AbhiDiva96
Copy link
Owner

just create here. I am reopening this issue

@swetha5157
Copy link
Contributor Author

OK @AbhiDiva96

@AbhiDiva96
Copy link
Owner

Screenshot_2024-05-30-12-55-37-77_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

why right side of header section taking space in desktop view. Pls fix it

@swetha5157

@swetha5157
Copy link
Contributor Author

Yes @AbhiDiva96 I'll make it centered..

@swetha5157
Copy link
Contributor Author

Hi @AbhiDiva96
Since the PR is closed my commits for the changes mentioned were not displayed.
But I have made the changes..
Screenshot 2024-05-31 093653
Video:

75.1.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants