Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full end to end #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

edwardcapriolo
Copy link

So this is a way to move the "examples" to actually working end to end. It is a real PITA to try to get schema registry classpath in this classpath and this embedded tool does it nice. But maybe testcontainers would be easier.

@cerveada
Copy link
Collaborator

cerveada commented Jun 9, 2021

The tests are failing because the license is missing in FullSpec.scala

@gintautassulskus-elsevier
Copy link
Contributor

There is a library for embedded Kafka-SchemaRegistry setup that does not require you to fiddle with installation, Java params and jars directly - https://github.com/embeddedkafka/embedded-kafka-schema-registry. Not sure though if you can use it to deploy Schema Registry without Kafka.

My advice would be to use testcontainers. Unlike an embedded service, the containerised counterpart is OS-agnostic. In the vast majority of cases such as proposed in this PR, an embedded service will not cause an issue, but it's that 1% that gives the most headaches.

For example, (embedded) Kafka is not supported on Windows leading to issues under certain circumstances (apache/kafka#6329 and KAFKA-1194).

There is a caveat if your CI runs on Kubernetes. Running testcontainers in a container (pod) necessitates a Docker-in-Docker setup that introduces a significant security risk and is a no go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants