Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support usage of CpsTable #14

Merged
merged 8 commits into from
May 13, 2024
Merged

Conversation

lukasmatta
Copy link
Collaborator

No description provided.

@lukasmatta lukasmatta self-assigned this May 10, 2024
@lukasmatta lukasmatta linked an issue May 10, 2024 that may be closed by this pull request
@fateeand
Copy link
Contributor

The only suggestion is to use

:root {
  --cps-mdoc-viewer-primary: var(--cps-color-calm);
  --cps-mdoc-viewer-secondary: var(--cps-color-prepared);
}

because of cps-table

@lukasmatta
Copy link
Collaborator Author

Do you mean to align cps-table coloring with the primary and secondary color? I started doing it, but then realized, it would be more effective to first make cps-ui-kit support theming and then just use --cps-mdoc-viewer-primary/secondary in the theme.

By theming in the cps-ui-kit I mean something like we are doing in this library - let the users define primary/secondary color and use those colors and their shades in the components. We can implement that gradually, so once CpsTableComponent will support it, it can be updated in this library.

@fateeand
Copy link
Contributor

fateeand commented May 10, 2024

Do you mean to align cps-table coloring with the primary and secondary color? I started doing it, but then realized, it would be more effective to first make cps-ui-kit support theming and then just use --cps-mdoc-viewer-primary/secondary in the theme.

By theming in the cps-ui-kit I mean something like we are doing in this library - let the users define primary/secondary color and use those colors and their shades in the components. We can implement that gradually, so once CpsTableComponent will support it, it can be updated in this library.

I mean exactly what I wrote above:
in styles.scss use

:root {
  --cps-mdoc-viewer-primary: var(--cps-color-calm);
  --cps-mdoc-viewer-secondary: var(--cps-color-prepared);
}

until cps-ui-kit will support custom colors (which is not going to happen soon).

@lukasmatta
Copy link
Collaborator Author

ahaa, I see now, thanks for explaining, colors are replaced now

@lukasmatta lukasmatta merged commit bf192df into master May 13, 2024
1 check passed
@lukasmatta lukasmatta deleted the 11-utilize-the-cpstablecomponent branch May 13, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize the CpsTableComponent
2 participants