fix: underlying issue of generate_range of signed integers being off by 1 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by 1 test: add tests for generate_ranges of length 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the underlying issue of
WyRand::generate_rangebeing off by 1.While this pull request allegedly was supposed to fix this earlier version of the issue, the underlying issue was not the
lowerbound on line 55 but rather the conversion from the unsigned to signed integer on line 64 being off by one. The change on line 55 introduced a new bug wherebygenerate_range(0..1)would be considered out of bounds.I added new tests for
generate_range(0..1)for signed as well as unsigned integer ranges.