Fix paymaster when using rainbowkit connector #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeexcoin
force-pushed
the
fix-paymaster
branch
from
7d12d9e to
06a9ac9
Compare
cygaar
reviewed
Sep 18, 2024
| @@ -125,15 +126,36 @@ function abstractWalletConnector( | |||
| transport, | |||
| }); | |||
|
|
|||
| const paymasterParams = params[0].eip712Meta.paymasterParams | |||
There was a problem hiding this comment.
I'll take a look into this PR a bit more closely - I have a feeling there might be an existing formatter in the zksync viem package than can help with this
cygaar
force-pushed
the
fix-paymaster
branch
from
06a9ac9 to
5e68f3d
Compare
coffeexcoin
commented
Sep 19, 2024
| // Formatter: https://github.com/wevm/viem/blob/main/src/zksync/formatters.ts#L114 | ||
| if (transaction.eip712Meta) { | ||
| transaction.paymaster = | ||
| transaction.eip712Meta.paymasterParams.paymaster; |
There was a problem hiding this comment.
Is it possible to have eip712Meta but no paymaster params? Might need a null check here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.