Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http transport for public client #8

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

cygaar
Copy link
Contributor

@cygaar cygaar commented Sep 16, 2024

The public client should always use the default http transport. I ran into this issue when I was experimenting and trying to pass in an EOA transport the other day. The zks rpc methods will fail since most wallets won't recognize those.

@cygaar cygaar requested a review from coffeexcoin September 16, 2024 22:57
@cygaar cygaar merged commit 4347f6c into main Sep 16, 2024
1 check passed
@cygaar cygaar deleted the update_public_client_transport branch September 16, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants