Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy for edx-enterpise #52

Merged
merged 2 commits into from
Nov 16, 2023
Merged

add proxy for edx-enterpise #52

merged 2 commits into from
Nov 16, 2023

Conversation

ghassanmas
Copy link
Contributor

@snglth we need a way that the caddy container would be connecting to certiain networks when the container gets recreated.
I am doing it maually through
docker network connect wordpress-network caddy-contianer and we would also need to do the same for enterpise network.. otherwise someone needs to run those command every time we the CI/CD redeploy them.

I think we have two resole this:

Let me know what's your opinoin on this

@snglth
Copy link
Member

snglth commented Nov 16, 2023

Are you sure that aee3fa7 belongs to this PR? Also, it doesn't seems like we automated docker network connect ....

@ghassanmas
Copy link
Contributor Author

Yes I changed it because certifcation is old and I think it's causing certifcate to not to work... it's not related to this PR but the change is needed

@ghassanmas
Copy link
Contributor Author

@snglth the automation of network, has been already handled through docker compose docker-compose.override.yml. I don't want to commit this file to this repo because it would break it for locally dev. but the file is there on the server.

For more context check overhangio/tutor#935

@snglth snglth merged commit 3f0ff61 into main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants