Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Migration locks to fungible freeze #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Anny0nn
Copy link
Member

@Anny0nn Anny0nn commented Dec 5, 2024

Migrations tested with try-runtime-cli and with chopsticks

# v0.8.0 has a bug with the blocktime config
cargo install --git https://github.com/paritytech/try-runtime-cli --tag v0.7.0 --locked --force

try-runtime create-snapshot  --uri wss://invarch-rpc.dwellir.com  --pallet System OcifStaking Balances

try-runtime \
    --runtime ./invarch/target/release/wbuild/invarch-runtime/invarch_runtime.compact.compressed.wasm \
    on-runtime-upgrade  \
    snap --path ./invarch_state.snap
[2024-12-05T01:46:34Z INFO  pallet_dao_staking::migrations::v1] Migrated 1986 locks
[2024-12-05T01:46:34Z INFO  pallet_dao_staking::migrations::v1] Migrated 19 daos
[2024-12-05T01:46:34Z INFO  pallet_dao_staking::migrations::v1] v1 applied successfully
[2024-12-05T01:46:34Z INFO  try_runtime_core::common::misc_logging] ---------------------------------------------------------------------------------


[2024-12-05T01:46:34Z INFO  try_runtime_core::common::misc_logging] 🔬 Running TryRuntime_on_runtime_upgrade again to check idempotency: PreAndPost


[2024-12-05T01:46:34Z INFO  try_runtime_core::common::misc_logging] ---------------------------------------------------------------------------------


[2024-12-05T01:46:34Z WARN  pallet_dao_staking::migrations::v1] Skipping v1, should be removed
[2024-12-05T01:46:35Z INFO  runtime::executive] ✅ Entire runtime state decodes without error. 6775484 bytes total.
[2024-12-05T01:46:35Z INFO  try-runtime::cli] PoV size (zstd-compressed compact proof): 984.2 KB. For parachains, it's your responsibility to verify that a PoV of this size fits within any relaychain constraints.
[2024-12-05T01:46:35Z INFO  try-runtime::cli] Consumed ref_time: 0.0038s (0.76% of max 0.5s)
[2024-12-05T01:46:35Z INFO  try-runtime::cli] ✅ No weight safety issues detected. Please note this does not guarantee a successful runtime upgrade. Always test your runtime upgrade with recent state, and ensure that the weight usage of your migrations will not drastically differ between testing and actual on-chain execution.

@Anny0nn Anny0nn requested a review from arrudagates December 5, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant