-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of structs in MaterialX #1831
Open
ld-kerley
wants to merge
12
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
ld-kerley:struct_experiment_dont_unfold
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Initial implementation of structs in MaterialX #1831
ld-kerley
wants to merge
12
commits into
AcademySoftwareFoundation:main
from
ld-kerley:struct_experiment_dont_unfold
Commits on Jun 11, 2024
-
Add support for recursive structs, with example.
Add "_struct" suffix to struct type name to avoid potential name clashes with variable names. Add AggregateValue to centralize struct string parsing. Add support for recursive structs in places - may not be complete yet - centralized syntax parsing - and unit tests pass currently. refactor struct experiment to not unfold the structs, but instead maintain them in the shaders
Configuration menu - View commit details
-
Copy full SHA for 1b7e4b7 - Browse repository at this point
Copy the full SHA 1b7e4b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for aece2c8 - Browse repository at this point
Copy the full SHA aece2c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42b3e6d - Browse repository at this point
Copy the full SHA 42b3e6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c193ebe - Browse repository at this point
Copy the full SHA c193ebeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f61af8 - Browse repository at this point
Copy the full SHA 2f61af8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74ee722 - Browse repository at this point
Copy the full SHA 74ee722View commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad6bb43 - Browse repository at this point
Copy the full SHA ad6bb43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9822a90 - Browse repository at this point
Copy the full SHA 9822a90View commit details
Commits on Jun 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b9291d7 - Browse repository at this point
Copy the full SHA b9291d7View commit details
Commits on Jun 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f640a82 - Browse repository at this point
Copy the full SHA f640a82View commit details
Commits on Jun 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4d9c5de - Browse repository at this point
Copy the full SHA 4d9c5deView commit details
Commits on Jul 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2d5287b - Browse repository at this point
Copy the full SHA 2d5287bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.