Generate symbol derivatives for outputs when requested #1916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, symbols are only flagged for derivative computation if
However, there's a fourth relevant case - when the renderer requests the symbol to be written as an output with derivatives. This is possible via
SymLocationDesc
, but in the current implementation, this only ends up writing derivatives if one of the three cases above also happens to be true.Therefore, detect this case and explicitly mark the symbol as requiring dependencies.
Tests
No tests at the moment since it would require extensive changes to testshade. Let me know if this is something that you'd consider necessary here.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.