Skip to content

Conversation

ggarra13
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.

Each PR should link at least one issue, in the form:

This is a test for issue #1652. It does not fix it. It just adds a test for it.

Summarize your change.

Added a test_find_children.cpp that shows the problem.

Reference associated tests.

test_find_children.cpp.

Signed-off-by: Gonzalo Garramuño <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.91%. Comparing base (eaf8569) to head (82c98c6).
⚠️ Report is 87 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files         197      197           
  Lines       21731    21731           
  Branches     4339     4339           
=======================================
+ Hits        17366    17367    +1     
  Misses       2213     2213           
+ Partials     2152     2151    -1     
Flag Coverage Δ
py-unittests 79.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf8569...82c98c6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meshula meshula added the bug A problem, flaw, or broken functionality. label Aug 20, 2023
@ssteinbach ssteinbach added this to the 1.0 Release milestone Mar 13, 2025
@jminor
Copy link
Collaborator

jminor commented Aug 6, 2025

It looks like this was covered by #1766
Feel free to reopen if I've misunderstood.

@jminor jminor closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem, flaw, or broken functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants