Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace backticks with quotes in pypi-publish GHA workflow #1837

Conversation

JeanChristopheMorinPerso
Copy link
Member

As the title says. Backticks are not valid in YAML.

Signed-off-by: Jean-Christophe Morin <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (c0e97b0) to head (de1bd46).
Report is 36 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   84.11%   84.75%   +0.63%     
==========================================
  Files         198      176      -22     
  Lines       22241    12711    -9530     
  Branches     4687     1181    -3506     
==========================================
- Hits        18709    10773    -7936     
+ Misses       2610     1760     -850     
+ Partials      922      178     -744     
Flag Coverage Δ
py-unittests 84.75% <ø> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 129 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e100920...de1bd46. Read the comment docs.

@darbyjohnston darbyjohnston merged commit 8373863 into AcademySoftwareFoundation:main Feb 5, 2025
62 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the fix_workflow branch February 6, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants