Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] don't find_library for libm to avoid absolute path in OpenEXRTargets.cmake #1376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

russelltg
Copy link

As is, if you do a

cmake -Bbuild -DBUILD_SHARED_LIBS=OFF -GNinja --fresh && DESTDIR=install ninja -C build install

then build/install/usr/local/lib/cmake/OpenEXR/OpenEXRTargets.cmake will reference the absolute path to libm, which is problematic for my usecase as I'm compiling against a sysroot then copying it and building against it elsewhere.

This fixes that problem by just linking to m instead of the path

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: russelltg / name: Russell Greene (6126950)

@cary-ilm
Copy link
Member

Thanks for the fix and the contribution. The ASWF policy is to require signed commits, could you possibly re-commit this with a -s? That will add the "signed-off-by" line. The best thing to do is to overwrite this commit with a force push, something like "git reset HEAD~1; git commit -s -m ; git push -f".

Alternatively, I'm happy to submit a separate PR with the change, to save you the hassle if you prefer. Thanks!

@lgritz
Copy link
Contributor

lgritz commented Apr 11, 2023

You don't need the git reset part. The following will do:

git commit --amend -s

(and then the force push)

This avoids losing any commit message you had originally.

@cary-ilm
Copy link
Member

@russelltg, this slipped through the cracks but we're about to make a release and would like to include this. Could you take a minute and amend the commit with the signoff? Or let me know and I'll submit a duplicate PR myself. Thanks!

cary-ilm added a commit to cary-ilm/openexr that referenced this pull request May 21, 2023
…cmake

Replication of AcademySoftwareFoundation#1376. Link against m instead of the complete path for libm.

Signed-off-by: Cary Phillips <[email protected]>
@cary-ilm
Copy link
Member

@russelltg, one more ping before the upcoming release, can you kindly sign the commit? Thanks!

@russelltg
Copy link
Author

Yep, sorry about the delay. Thanks for the pings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants