Bazel build fixes. #1836
Merged
Bazel build fixes. #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asa <[email protected]>
Closed
|
@Vertexwahn @cary-ilm can I get a review? |
cary-ilm
approved these changes
Sep 22, 2024
| @@ -17,9 +17,9 @@ | |||
| // | |||
|
|
|||
| #ifndef INCLUDED_OPENEXR_VERSION_H | |||
| #define OPENEXR_VERSION_MAJOR @OpenEXR_VERSION_MAJOR@ | |||
There was a problem hiding this comment.
I'm curious what prompted this change? It should be benign, as I believe OPENEXR_VERSION_* and OpenEXR_VERSION_* have the same values. Not opposed to it, just wondering why it should change.
There was a problem hiding this comment.
When migrating to bazel we take and make bazel versions of these macros, and having them all consistently upper case seams cleaner for these kinds of external automation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few fixes I needed to get the included bazel file to play nice with OpenImageIO.
I believe they are general enough to be included for others.
I squashed the previous PR (#1816 )work into this new branch and pushed it here instead.