Add templated utility class to centralize common pattern #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All reading code has a (for threaded reads) need to maintain a set of contexts and re-use them while dispatching N threads. Create a class to do that and remove duplicate code. This also lowers the scope of when the contexts are alive to reduce memory bloat Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
approved these changes
Sep 23, 2024
|
@kdt3rd and @fnordware, just to confirm, does this fully address the intentions of #1834, so we can discard that proposed change? |
|
Oooh. Yes, this does address my issue since now the memory is allocated and deallocated in each readTiles() and readPixels(). I thought this might be a performance hit, especially if the image read was broken up into many readTiles() and readPixels() calls, but in my testing it doesn't appear to be. Bravo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All reading code has a (for threaded reads) need to maintain a set of contexts and re-use them while dispatching N threads. Create a class to do that and remove duplicate code.
This also lowers the scope of when the contexts are alive to reduce memory bloat.
Inspiration to do this based on a patch #1834 from @fnordware