analysis

[antond-weta]

Description

Set up static analysis CI action.

Was planning on using SonarCloud, but that seemed too complicated to me, so I ended up using Clang static analyser via CodeChecker.

This PR also fixes all existing SA warnings, so SA check should pass.

Tests

No tests as this PR doesn't introduce any new code. It does change some code to fix warnings, mostly just variable renaming end explicit casting.

Checklist:

• I have read the contribution guidelines.
• I have updated the documentation, if applicable. (Check if there is no
  need to update the documentation, for example if this is a bug fix that
  doesn't change the API.)
• I have ensured that the change is tested somewhere in the testsuite
  (adding new test cases if necessary).
• My code follows the prevailing code style of this project. If I haven't
  already run clang-format before submitting, I definitely will look at the CI
  test that runs clang-format and fix anything that it highlights as being
  nonconforming.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 62.35294% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.30%. Comparing base (bbb6200) to head (b331e21).

Files with missing lines	Patch %	Lines
src/rawtoaces_util/image_converter.cpp	36.11%	23 Missing ⚠️
src/rawtoaces_core/rawtoaces_core.cpp	82.85%	6 Missing ⚠️
src/rawtoaces_core/spectral_data.cpp	78.57%	3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (62.35%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   72.27%   72.30%   +0.02%     
==========================================
  Files          10       10              
  Lines        2348     2354       +6     
  Branches      311      311              
==========================================
+ Hits         1697     1702       +5     
- Misses        651      652       +1     

Files with missing lines	Coverage Δ
include/rawtoaces/image_converter.h	100.00% <ø> (ø)
include/rawtoaces/rawtoaces_core.h	100.00% <ø> (ø)
src/rawtoaces_core/define.h	96.61% <ø> (ø)
src/rawtoaces_core/mathOps.h	99.30% <ø> (ø)
src/rawtoaces_core/spectral_data.cpp	76.71% <78.57%> (+1.24%)	⬆️
src/rawtoaces_core/rawtoaces_core.cpp	86.12% <82.85%> (-0.03%)	⬇️
src/rawtoaces_util/image_converter.cpp	54.00% <36.11%> (-0.11%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb6200...b331e21. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[soswow]

nice