Add missing close button decorator to tool windows (missing on Windows builds). Fixes #109. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…s builds). Fixes AcademySoftwareFoundation#109. Signed-off-by: John Kelly <[email protected]>
aloyisus
force-pushed
the
fix_missing_buttons_issue_109
branch
from
ccd61d5
to
f18a8ef
Compare
|
There is an issue with that, the notes and draw panel don´t show up, so your fix for the button doesnt work with xstudio-0.12.0 build for Windows. |
|
Sorry for delay with replying @jonbragado. I am building 0.12.0 for Windows and the buttons are showing up on all panels including Notes and Drawing Tools, so I can't reproduce what you're seeing. Can you provide some more info? Here's a screengrab from my build with the close buttons added (also worth noting that I have not been able to test this on Linux).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a close button to tool panels e.g. Python Console, Notes etc, which is otherwise missing in a Windows build.