-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hyper version to v1 #184
Conversation
Specifying port 0 in tests
@xlc Why port 0 is used for those tests? |
port 0 usually means let the system to allocate an unused port |
I see, in that case, the cause is really clear. I needed to return |
Resolve #185
The latest jsonrpsee release bumped its dependency hyper's version to v1.
https://github.com/paritytech/jsonrpsee/releases/tag/v0.23.0
This introduced low level api removal such as
hyper::service::make_service_fn
, and some others. See https://hyper.rs/guides/1/upgrading/. SubwayServerBuilderbuild
function need to be updated accordingly.Because we want to make use of a new feature added to jsonrpsee, hyper version upgrades is required as a first step.
paritytech/jsonrpsee#1388
paritytech/jsonrpsee#1389