feat(lh): add lighthouse mobile report #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In french ( english below )
Hello,
Je propose d'ajouter une analyse lighthouse mobile, avec une taille d'écran de 430 par 932, qui correspond à la résolution d'un iphone 14 depuis le simulateur mobile chrome.
Pour ça, j'ai ajouté un élément "mobile" dans le rapport lighthouse, pour ne pas casser le fonctionnement actuel.
La sortie du rapport contient un élément mobile, à la fois pour les rapports mais aussi pour la dernière analyse.
J'ai aussi modernisé une partie du code, en ajoutant quelques tests avec Jest, et en refactorant la partie qui présente les données lighthouse pour la sortie d'api.
Je n'ai pas ajouté l'affichage dans le plugin Sonar, car il pourrait être intéressant de procéder de la même manière pour le rapport desktop existant.
exemple :
D'ailleurs, sur le même modèle, je pense qu'ajouter une analyse ecoindex mobile est aussi possible.
English :
Hello,
I propose to add a mobile lighthouse analysis, with a screen size of 430 by 932, which corresponds to the resolution of an iphone 14 from the chrome mobile simulator.
For this, I've added a "mobile" element to the lighthouse report, so as not to break the current operation.
The report output contains a mobile element, both for reports and for the latest analysis.
I've also modernized some of the code, adding some tests with Jest, and refactoring the part that presents the lighthouse data for the api output.
I haven't added the display in the Sonar plugin, as it might be interesting to do the same for the existing desktop report.
example :
By the way, on the same model, I think adding a mobile ecoindex analysis is also possible.