Add EdgeInsets helper inits #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leinhauplk
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
🤔 Why do you have two identical files with tests? I would prefer one file in two target. As in the case of EdgeInsetsExtensions.swift.
There was a problem hiding this comment.
That will be fixed once #140 is merged, so we can live with that for now I think 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with
EdgeInsetsin SwiftUI, we often use same insets for all edges. Usually it can be solved by using.padding(5)modifier and not.padding(EdgeInsets(...))but once insets become a parameter or return value, working with it becomes a bit annoying, thanks to these new initializers, it will be less annoying.Wanted to add also expressible by literal conformances, but that makes
view.padding(5)ambiguous so not doing that.Checklist