Update Golang versions for CircleCI #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrohmann
approved these changes
Jun 10, 2024
swagile1
force-pushed
the
swarden/update-go-circleci-version
branch
from
224d4e7
to
5cfad72
Compare
mdrohmann
approved these changes
Jun 11, 2024
Comment on lines
+12
to
+18
| require ( | ||
| github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 // indirect | ||
| github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d // indirect | ||
| github.com/davecgh/go-spew v1.1.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| gopkg.in/yaml.v2 v2.2.2 // indirect | ||
| ) |
There was a problem hiding this comment.
Is tat correct? There are now two require(..) blocks?
There was a problem hiding this comment.
I think go mod separates direct and indirect dependencies into distinct blocks. This is the first time I've seen it though.
mdrohmann
changed the base branch from
master
to
swarden/update-go-circleci-version
mdrohmann
changed the base branch from
swarden/update-go-circleci-version
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.