Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified rewrite based on photostorm/pty for Windows support #9

Open
wants to merge 123 commits into
base: master
Choose a base branch
from
Open

Simplified rewrite based on photostorm/pty for Windows support #9

wants to merge 123 commits into from

Conversation

Naatan
Copy link
Member

@Naatan Naatan commented Nov 24, 2022

No description provided.

@Naatan
Simplified rewrite based on photostorm/pty for Windows support
1f59ff9
@Naatan
Clean up helpers
316aaaa
@Naatan
WIP
723acd1
@Naatan
WIP fix order of operation
0775f1d
@Naatan
Drop overzealous channel closing mechanic, fix tests
d7d1070
@Naatan
Streamlined option handling. Fixed channel closing issues. Improved e…
c8c6e17 
…rror reporting.
@Naatan
Add example tests
eff77a9
@Naatan
Move responsibility of tracking position to outputProducer
03d2a87
@Naatan
Fix timeout not being respected
0290250
@Naatan
Remove todo comment that has already been resolved
501d5d7
@Naatan
Fix test not exiting
ec49284
@Naatan
Test files only contain tests
7034515
@Naatan
Ignore intellij .idea folder
71af4ba
@Naatan
Fix panic if command executable can't be found
1711419
@Naatan
Refactor to address test cases. Primarily the change here is that the…
cab244e 
… outputproducer now tracks the position in the buffer.
@Naatan
Ensure cmd is tested
a93c2e4
@Naatan
Fix test failing on mac because input is sent too soon
fd91770
@Naatan
Fix test using wrong shell
996b10a
@Naatan
Clean up debugging code
9d0e991
@Naatan
Drop proof of concept code
17ec740
@Naatan
Set up test automation
d4a17c4
@Naatan
Format test results
a9c1f4c
@Naatan
Debug gotestfmt not on PATH
1cf3ff4
@Naatan
Run go mod tidy
364d0f2
@Naatan
Debug go version
faeba65
@Naatan
Apparently github actions doesn't recognize zero's cause it installed…
43235cb 
… 1.2...
@Naatan
Prioritize regular tests and report all failures at the end
a628c73
@Naatan
Trim NULL bytes from output
0a6f5c5
@Naatan
Fix race condition
b5d332d
@Naatan
Debug
8d20245
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Naatan
❌ mitchell-as
You have signed the CLA already but the status is still pending? Let us recheck it.

@Naatan
Reimplement process exit expect failure
fddafcc 
Avoid cyclic dependencies; output consumers or producers should have no awareness of termtest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naatan @CLAassistant @mitchell-as