Add default configuration #236
Open
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to set default options for acts_as_paranoid globally
Jay-Schneider
commented
May 25, 2021
| } | ||
|
|
||
| temporary_paranoiac = Class.new(ActiveRecord::Base) do | ||
| acts_as_paranoid |
There was a problem hiding this comment.
It is kind of important, that the class definition (rather this method call) is done after setting up the config, while I didn't want to change the behaviour of all other paranoiacs used in the tests. This is why I create this class inside of the test.
|
Thanks @Jay-Schneider, I think it's a really good idea to have a default configuration. Regarding where the configuration should live, I think it makes sense if it lives in ActsAsParanoid itself, so users can set |
|
What's the status of this PR? and @mvz is it configurable like that? |
|
👍 |
… add-default-configuration # Conflicts: # test/test_helper.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #234
I think the implementation is rather straight forward, I am a bit concerned about testing this feature though. I came up with something that verifies the functionality of the feature but I needed to wiggle some things to make it work.
Since I usually use RSpec I am uncertain how to mock away the rails config with minitest. Also the necessity to do so maybe is a pointer that configuration of acts_as_paranoid should be handled differently? Please let me know what you think about it @mvz 🙂