Center flexible length text & clear manualCaptureInput on open #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR carries two enhancements:
manualCaptureInputvalue when manual capture is initiated. The file upload path only fires when themanualCaptureInputvalue changes (manualCaptureInput.onchange). There are times when a user may want to try to upload the same image more than once, this enhancement allows for that.Please note: The code base does not make it clear how the code is minified, so we were not able to update the minified file as well. If these updates are approved, we will need the minification to be run as well.
One other suggestion (that is not related to this PR): It seems that the code is either not being transpiled or is not being transpiled to support that broad of an audience. It seem like the use of arrow functions (
=>) is causing some browsers to throw irrecoverable errors. Would it be possible to add a fix for this (if we had access to your build pipeline/tooling we could help contribute here as well).