Skip to content

Vera - Time #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,31 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)
def max_sub_array(nums)
Comment on lines +1 to 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
end
return nil if nums.empty?
return nums[0] if nums.length == 1

max_so_far = nums.min
max_ending_here = 0

index = 0
pointer2 = 1
while index <= nums.length - 1 || pointer2 <= nums.length - 1
max_ending_here = max_ending_here + nums[index]
if max_ending_here > max_so_far
max_so_far = max_ending_here
index += 1
else
max_ending_here = 0
max_ending_here = max_ending_here + nums[pointer2]
pointer2 += 1
index = pointer2
end
end

if max_so_far < max_ending_here
max_so_far = max_ending_here
end

return max_so_far
end
21 changes: 17 additions & 4 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@
# Time complexity: o(n)
# Space Complexity: o(1)
def newman_conway(num)
Comment on lines +1 to +3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a space complexity of O(n) because you're building array.

raise ArgumentError if num == 0
return "1" if num == 1
return "1 1" if num == 2

array = [0,1,1]
string = ""

# Time complexity: ?
# Space Complexity: ?
def newman_conway(num)
raise NotImplementedError, "newman_conway isn't implemented"
(3..num).each do |i|
array.push(array[array[i - 1]] + array[i - array[i - 1]])
end

(1..array.length - 1).each do |i|
array.length - 1 == i ? string << "#{array[i]}" : string << "#{array[i]} "
end

return string
end
16 changes: 8 additions & 8 deletions test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand All @@ -25,7 +25,7 @@

it "will work with a totally negative array with the largest element at the rear" do
# Arrange
input = [ -4, -5, -6, -7, -3]
input = [-4, -5, -6, -7, -3]

# Act
answer = max_sub_array(input)
Expand All @@ -46,14 +46,14 @@
end

it "will return nil for an empty array" do
# Arrange
input = []
# Arrange
input = []

# Act
answer = max_sub_array(input)
# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_be_nil
# Assert
expect(answer).must_be_nil
end

it "will work for [50, -50, 50]" do
Expand Down