Skip to content

Time - Jocelyn #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def max_sub_array(nums)
Comment on lines +2 to 4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
return nums.inject(:+) if nums.length <= 3

max_so_far = nums[0]
max_ending_here = nums[0]

nums.each do |num|
if max_ending_here < num
max_ending_here = num
elsif num < max_ending_here
max_ending_here += num
end

if max_so_far < max_ending_here
max_so_far = max_ending_here
end
end

return max_so_far
end
23 changes: 19 additions & 4 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,22 @@
# Time complexity: O(n)
# Space Complexity: O(n)
def newman_conway(num)
Comment on lines +1 to +3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise ArgumentError if num == 0
array = [num, 0]

count = 1

until count > num
if count == 1 || count == 2
array[count] = 1
else
array[count] = array[array[count - 1]] + array[count - array[count - 1]]
end

count += 1
end

# Time complexity: ?
# Space Complexity: ?
def newman_conway(num)
raise NotImplementedError, "newman_conway isn't implemented"
p array[1..(array.length - 1)].join(' ')

array[1..(array.length - 1)].join(' ')
end
2 changes: 1 addition & 1 deletion test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down