Skip to content

Time - Haben #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Time - Haben #25

wants to merge 3 commits into from

Conversation

HabenFoto
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall well done, one problem with height, see my comments and let me know what questions you have.

Comment on lines +32 to 34
# Time Complexity:
# Space Complexity:
def add(key, value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +54 to +57
# Time Complexity: O(n)
# Space Complexity: O(n)

def find_recursive(current, key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a recursive version, nice 👍

end

# Time Complexity:
# Space Complexity:
def inorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

end

# Time Complexity:
# Space Complexity:
def preorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

end

# Time Complexity:
# Space Complexity:
def postorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +130 to 133
# Time Complexity:
# Space Complexity:

def height

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ , Time complexity O(n) and space complexity O(h) where h is the height of the tree.

However I don't think this method works because it assumes the longest lengths of the trees are on the left and right edges, not somewhere in the middle.

An alternative solution which I think does work

    def height_helper(current, count)
      return count if current.nil?

      return [height_helper(current.left, count + 1), height_helper(current.left, count + 1)].max
    end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants