-
Notifications
You must be signed in to change notification settings - Fork 44
Time - Haben #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Time - Haben #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall well done, one problem with height, see my comments and let me know what questions you have.
# Time Complexity: | ||
# Space Complexity: | ||
def add(key, value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time Complexity: O(n) | ||
# Space Complexity: O(n) | ||
|
||
def find_recursive(current, key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also a recursive version, nice 👍
end | ||
|
||
# Time Complexity: | ||
# Space Complexity: | ||
def inorder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
end | ||
|
||
# Time Complexity: | ||
# Space Complexity: | ||
def preorder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
end | ||
|
||
# Time Complexity: | ||
# Space Complexity: | ||
def postorder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time Complexity: | ||
# Space Complexity: | ||
|
||
def height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h
is the height of the tree.
However I don't think this method works because it assumes the longest lengths of the trees are on the left and right edges, not somewhere in the middle.
An alternative solution which I think does work
def height_helper(current, count)
return count if current.nil?
return [height_helper(current.left, count + 1), height_helper(current.left, count + 1)].max
end
No description provided.