Pr 4 #4
Pr 4 #4
Conversation
| for filename in files: | ||
| if filename.endswith(".xml"): | ||
| xml_file = filename | ||
| break |
There was a problem hiding this comment.
Would we want to change this for a scenario where there are more than one xml files?
| from find_xml_file.find_xml_file import find_xml_file | ||
|
|
||
|
|
||
| def test_no_files_returns_None(): |
There was a problem hiding this comment.
Are we testing for a specific file? It might be helpful to be more descriptive here. "test_no_xml_files_returns_None():"
| xml_file = filename | ||
| break | ||
|
|
||
| return xml_file |
There was a problem hiding this comment.
is there only one xml file anticipated. What if there is more than one.
| import os | ||
|
|
||
|
|
||
| def find_xml_file(folder): |
There was a problem hiding this comment.
What about the instance of more than one xml files?
| @@ -0,0 +1,10 @@ | |||
| from find_xml_file.find_xml_file import find_xml_file | |||
There was a problem hiding this comment.
This naming could be confusing. Can we rename these files?
There was a problem hiding this comment.
What a great suggestion, Dani!
There was a problem hiding this comment.
Since there is only one method in file, maybe we can leave this as is OR rename the file where the method lives, so its is not redundant.
| def find_xml_file(folder): | ||
| files = os.listdir(folder) | ||
|
|
||
| xml_file = None |
There was a problem hiding this comment.
This might need to be renamed xml_files if we are going to possibly grab more than one.
|
|
||
| xml_file = None | ||
|
|
||
| for filename in files: |
|
|
||
|
|
||
| def find_xml_file(folder): | ||
| files = os.listdir(folder) |
There was a problem hiding this comment.
can we try to find a more descriptive variable name like user_files
No description provided.