Pr-7 #7
Pr-7 #7
Conversation
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| class Node { | |||
| constructor(value, next) { | |||
There was a problem hiding this comment.
what if we used a default null value for the next property?
| } | ||
|
|
||
| getNext() { | ||
| return this.next; |
There was a problem hiding this comment.
Would there ever be a situation where this would be called and there is no next value?
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| class Node { | |||
There was a problem hiding this comment.
Should we add context here to explain what this Node class is supposed to do? Looks like a linked list to me, but some context might be helpful for others!
| } | ||
| } | ||
|
|
||
| export default Node; |
| @@ -0,0 +1,34 @@ | |||
|
|
|||
There was a problem hiding this comment.
Does a default value need to be declared for value and next in the constructor?
|
|
||
| class Node { | ||
| constructor(value, next) { | ||
| this.value = value; |
There was a problem hiding this comment.
What does 'this' refer to exactly? Is it an instance of the Node class?
| constructor(value, next) { | ||
| this.value = value; | ||
| this.next = next; | ||
| } |
There was a problem hiding this comment.
using "value" and "next" in conjunction with "this" seems confusing from a readability standpoint. what is this.next referring to?
| return this.value; | ||
| } | ||
|
|
||
| setValue(value) { |
There was a problem hiding this comment.
Can we review this as being necessary or if it can be more concise?
| @@ -0,0 +1,34 @@ | |||
|
|
|||
There was a problem hiding this comment.
Consider adding a Docstring/comment on the class.
It seems to me that the class Node is part of the implementation of a linked list, it would be nice to not have to read all the code to get to know that.
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| class Node { | |||
| constructor(value, next) { | |||
There was a problem hiding this comment.
Consider adding comments on these variables, what sort of thing you expect a value to be? What sort of thing you expect next to be?
| this.value = value; | ||
| } | ||
|
|
||
| printList() { |
There was a problem hiding this comment.
printList will print all values from the node "this", onwards. If "this" is not the root of the linked list, It won't print the whole list. Is this the expected behavior?
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| class Node { | |||
There was a problem hiding this comment.
What is the purpose of this constructor? What is value and what is next? Should we have more specific naming here?
| return this.next; | ||
| } | ||
|
|
||
| setNext(next) { |
There was a problem hiding this comment.
Can you explain to me what the difference between setNext and setValue will be in the overall code?
| this.next = next; | ||
| } | ||
|
|
||
| getValue() { |
There was a problem hiding this comment.
Can you please explain to me which value this function will 'get'? In other words, how is the value being searched and retrieved here?
| } | ||
| } | ||
|
|
||
| export default Node; |
There was a problem hiding this comment.
This code looks really great, there are just a few things that I would appreciate some clarity on, thank you!
| constructor(value, next) { | ||
| this.value = value; | ||
| this.next = next; | ||
| } |
| while (current != null) { | ||
| console.log(current.value); | ||
| current = current.getNext(); | ||
| } |
| return this.value; | ||
| } | ||
|
|
||
| setValue(value) { |
There was a problem hiding this comment.
Just practicing writing comments here, lol
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| setNext(next) { | ||
| this.next = next; | ||
| } | ||
|
|
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| class Node { | |||
There was a problem hiding this comment.
Dittoing on the above. This is a practice post
No description provided.