Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock - Hannah L. #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions heaps/heap_sort.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@

from heaps.min_heap import MinHeap

def heap_sort(list):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Since you are building a heap here, the space complexity is O(n) because you build a heap of n elements.

""" This method uses a heap to sort an array.
Time Complexity: ?
Space Complexity: ?
"""
pass
Time Complexity: O log(n)
Space Complexity: O (1) """
heap = MinHeap()
# adding element in list
for elem in list:
heap.add(elem)

sorted_list = []
while heap.store:
# remove
elem = heap.remove()
# append sorted element
sorted_list.append(elem)

return sorted_list
62 changes: 40 additions & 22 deletions heaps/min_heap.py
Original file line number Diff line number Diff line change
@@ -1,40 +1,44 @@
class HeapNode:

def __init__(self, key, value):
self.key = key
self.value = value

def __str__(self):
return str(self.value)

def __repr__(self):
return str(self.value)



class MinHeap:

def __init__(self):
self.store = []


def add(self, key, value = None):
""" This method adds a HeapNode instance to the heap
If value == None the new node's value should be set to key
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
Comment on lines 15 to +19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"""
pass
if value == None:
value = key

node = HeapNode(key, value)
self.store.append(node)
self.heap_up(len(self.store) -1)

def remove(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" This method removes and returns an element from the heap
maintaining the heap structure
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
"""
pass

if len(self.store) == 0:
return

self.swap(0, len(self.store) - 1)
min = self.store.pop()
self.heap_down(0)

return min.value

def __str__(self):
""" This method lets you print the heap, when you're testing your app.
Expand All @@ -46,10 +50,10 @@ def __str__(self):

def empty(self):
""" This method returns true if the heap is empty
Time complexity: ?
Space complexity: ?
Time complexity: O(1)
Space complexity: O(1)
"""
pass
return len(self.store) == 0
Comment on lines 51 to +56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍



def heap_up(self, index):
Expand All @@ -59,25 +63,39 @@ def heap_up(self, index):
property is reestablished.

This could be **very** helpful for the add method.
Time complexity: ?
Space complexity: ?
Time complexity: O(1)
Space complexity: O(1)
"""
pass
if index == 0:
return

parent = (index -1) // 2
if self.store[index].key < self.store[parent].key:
self.swap(index, parent)
self.heap_up(parent)

def heap_down(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work

""" This helper method takes an index and
moves the corresponding element down the heap if it's
larger than either of its children and continues until
the heap property is reestablished.
"""
pass
min_child_index = 2 * index + 1
child2_index = 2 * index + 2
if child2_index < len(self.store) and self.store[child2_index].key < self.store[min_child_index].key:
min_child_index = child2_index

if min_child_index >= len(self.store):
return None
elif self.store[min_child_index].key < self.store[index].key:
self.swap(index, min_child_index)
self.heap_down(min_child_index)


def swap(self, index_1, index_2):
""" Swaps two elements in self.store
at index_1 and index_2
used for heap_up & heap_down
"""
temp = self.store[index_1]
self.store[index_1] = self.store[index_2]
self.store[index_2] = temp
self.store[index_2] = temp