Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C15 Rock Alison McGinley #45

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

alisonmcginley
Copy link

No description provided.

Copy link

@spitsfire spitsfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can tell you had a LOT of fun with this, Al! Your CSS is fun and experimental! Keep up the great work!

<h2>Body of work</h2>
</header>
<hr>
<nav class="port-container">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason you went with a nav element here? My accessibility is rusty, but I'm wondering if this would confused a screen reader. I wonder if we should use a section instead maybe?

@@ -0,0 +1,63 @@
/* broad styling strokes */
@keyframes fadein {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,29 @@
/* broad styling strokes */
@keyframes fadein {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants