Paper | Karla T #67
Open
Paper | Karla T #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Jun 23, 2021
| <link href="https://fonts.googleapis.com/css2?family=Source+Code+Pro:ital,wght@1,300&family=Viaoda+Libre&display=swap" rel="stylesheet"> | ||
|
|
||
| <!-- link to index--> | ||
| <href class="nav-link"><a href="index.html">Back to Main Page!</a></li> |
There was a problem hiding this comment.
href is not a tag. Did you mean to make it an li. Also this should be inside the body.
Suggested change
| <href class="nav-link"><a href="index.html">Back to Main Page!</a></li> | |
| <li ><a href="index.html">Back to Main Page!</a></li> |
| <link href="https://fonts.googleapis.com/css2?family=Source+Code+Pro:ital,wght@1,300&family=Viaoda+Libre&display=swap" rel="stylesheet"> | ||
|
|
||
| <!-- link to index--> | ||
| <href class="navi-link"> <a href="index.html">My photos</a></li> |
| <header > | ||
| <div class="logo"> | ||
| <!-- <img src="img/About me Photo.JPG" alt=""> --> | ||
| <button class="nav-toggle" aria-label="toggle navigation"> |
There was a problem hiding this comment.
You can't really make a ul a child of a button. Usually you just put text inside a button tag.
| <li class="nav__item"><a href="#work" class="nav__link">My Work</a></li> | ||
| </ul> | ||
| </nav> | ||
| </div> |
| <p>I am a student of computer science. Diving into this field with high spirits and full of life!</p> | ||
| </div> | ||
|
|
||
| <img src="img/Everyday_Shots_Buttercup_inSunset.JPG" class="about-me__img"> |
There was a problem hiding this comment.
Images should have an alt attribute for accessibility and in case the image doesn't render.
| .section__subtitle--about { | ||
| background: var(--clr-accent); | ||
| font-family: var(--ff-secondary); | ||
| margin-bottom: 1 em; |
There was a problem hiding this comment.
The margin can't be in em I think.
Suggested change
| margin-bottom: 1 em; | |
| margin-bottom: 5px; |
| z-index: 100; | ||
|
|
||
| transform: translateX(100%); | ||
| transition: transform 250ms cubic-bexier(.5, 0, .5, 1); |
There was a problem hiding this comment.
I'm not sure this is a transition value.
| .portfolio { | ||
| display: grid; | ||
| grid-template-columns: repeat(auto-fit, minmax(300px, 1fr)); | ||
| max-width: 0 auto; |
There was a problem hiding this comment.
You can't give 0 auto; as a max width.
| text-decoration: none; | ||
| } | ||
|
|
||
| .footer__link:hoover, |
| opacity: .7; | ||
| } | ||
|
|
||
| .footer__link:hoover{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.